Skip to content

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Oct 17, 2025

JIRA ticket: LIMS-1917

Summary:

There is no mechanism for SynchWeb to be able to display the status of MX strategy/screening jobs. SynchWeb currently looks for records in the Screening table and if a record exists it will show the results of the pipeline and show that the job has completed. If a pipeline doesn't complete (even for a legitimate reason), there will be no record in SynchWeb that the pipeline has run. It would be good if SynchWeb could show the status of the pipeline (running, completed or failed) in the same way that it does for the autoprocessing and downstream pipelines.

The autoprocessing and downstream pipelines store their processing status in the AutoProcProgram table. The Screening table of ISPyB already contains autoProcProgramId as a foreign key which would allow a Screening record to be easily linked to an AutoProcProgram record.

The changes needed to the analysis pipelines will be deployed in January when @pblowey is back from parental leave, but the Synchweb changes can be done ready.

Changes:

  • Get ScreeningStrategyWedge.comments for the alignment axes, rather than Screening.comments (both are currently populated, but the latter will not be in future)
  • Display space group and unit cell for alignment pipelines, rounded to 2 decimal places
  • Return screening statuses from the backend as an array, rather than a single value
  • Get screening statuses with an autoProcProgramId as well as those without one. Merge the 2 arrays.
  • Display "xia2-dials+dials.align_crystal" results in the same way as "dials.align_crystal" results. This means that LIMS-1904: Display new xia2-dials+dials.align_crystal pipeline #989 is superseded.

To test:

  • Add 'xia2-dials+dials.align_crystal' to the $strat_align config variable, so it becomes
$strat_align = array('XOalign', 'dials.align_crystal', 'xia2-dials+dials.align_crystal');
  • Go to an old screening run (eg /dc/visit/mx19800-74/id/6110714), check this is now shown as 2 mosflm successes and 4 EDNA successes, rather than one for each
  • Go to /dc/visit/mx23694-144/id/19622929, where @pblowey has deliberately set 3 runs of "xia2-dials+dials.align_crystal", 1 each for success/failure/pending
  • Check the Strategies bar shows 3 successes for "dials.align_crystal", and 1 success, 1 failure and 1 pending for "xia2-dials+dials.align_crystal"
  • Expand the Strategies bar, check the 4 successes are shown, complete with space group and unit cell
  • Check the Downstream Processing bar shows "No Processing Results", and if you expand it, it says "No downstream processing available for this data collection"

@ndg63276 ndg63276 marked this pull request as ready for review October 17, 2025 12:34
_.each(res['screening'], function(sc, n) {
this.ui.strat.append(n+': '+val[sc]+' ')
var strats = {}
_.each(sc, function(a) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could maybe use native JS here, but it doesn't bother me too much

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R5.1 October 28, 2025 11:26
@ndg63276 ndg63276 merged commit f8ead87 into pre-release/2025-R5.1 Oct 28, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1917/track-status-of-strategy-pipelines branch October 28, 2025 11:28
ndg63276 added a commit that referenced this pull request Nov 11, 2025
* LIMS-1759: Add pages to create and view ligands (#957)

* LIMS-1759: Add pages to add/view/list ligands, add PDBS, and add to samples

* LIMS-1759: Add ligands to samples in plates

* LIMS-1759: Fix bug where ligands were added multiple times

* LIMS-1759: Fix error with too few args

---------

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1926: Hide barcode field when viewing a puck (#991)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1963: Load all logins for a proposal (#998)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1917: Track status of strategy pipelines (#993)

* LIMS-1917: Track status of strategy pipelines

* LIMS-1917: Hide strategy pipelines from downstream results

---------

Co-authored-by: Mark Williams <[email protected]>

---------

Co-authored-by: Mark Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants