Skip to content

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Oct 22, 2025

JIRA ticket: LIMS-598

Summary:

If an anode.html file is attached to the dimple processing job, display a button to show the map.

Changes:

  • Return the attachment id from the backend of anode.html (if present)
  • Show a button if the attachment id is not null
  • Use the download functionality to open the file and display the map (NB there should probably be a way to actually download html attachments, but that is a separate ticket)

To test:

  • Find a data collection with a dimple run with anode.map attached, eg
select concat('/dc/visit/', proposalCode, proposalNumber, '-', visit_number, '/id/', dataCollectionId) from AutoProcProgramAttachment inner join AutoProcProgram using (autoProcProgramId) inner join ProcessingJob using (processingJobId) inner join DataCollection using (dataCollectionId) inner join BLSession using (sessionId) inner join Proposal using (proposalId) where filename='anode.html' order by autoProcProgramAttachmentId desc limit 1;
  • If none found, @rowanwalker96 can manually run a job to create one
  • Open the Downstream Processing bar, and select the Dimple tab
  • Check a new button appears labelled "Interactive Viewer" for any dimple run with an anode.html attached
  • Check if you click the button, it loads up a map/model viewer

@gfrn
Copy link
Collaborator

gfrn commented Oct 28, 2025

There are a few cases in which anode peak plots go out of bounds and cause a horizontal scroll bar to appear (they also overlap buttons for the next processing job)
image

@ndg63276
Copy link
Collaborator Author

There are a few cases in which anode peak plots go out of bounds and cause a horizontal scroll bar to appear (they also overlap buttons for the next processing job)

Do you have an example?

@gfrn
Copy link
Collaborator

gfrn commented Oct 29, 2025

The screenshot is from /dc/visit/nt40663-6/id/20218396, which has now been deleted on account of Rowan running dimple against the restore database, but I can ask him to do it again if needed

My screen is also 1700px wide, so it's slightly smaller than a full widescreen window

@ndg63276
Copy link
Collaborator Author

Hmmm... all the data collections in that visit look ok to me (at first glance). Did you have /dls/ mounted, as there should be a dimple blob shown on the right?

@gfrn
Copy link
Collaborator

gfrn commented Oct 29, 2025

I didn't have /dls mounted, but I was expecting the image placeholder to take up the same amount of space as a regular image, so maybe that's it

@ndg63276
Copy link
Collaborator Author

Ok, I've now made the min-height of the blobs div larger if there are anode results, so the layout stays the same even if there is no image to display.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R5.2 November 11, 2025 11:38
@ndg63276 ndg63276 merged commit 25cec85 into pre-release/2025-R5.2 Nov 11, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-598/show-anode-maps branch November 11, 2025 11:41
ndg63276 added a commit that referenced this pull request Nov 20, 2025
* LIMS-1957: Fix fault report URLs for beamlines with hyphens (#997)

* LIMS-1952: Add select all button to multicrystal page (#999)

* LIMS-1951: Fix reprocessing on Auto Processing Status Summary page (#996)

* LIMS-1753: View of all inspection images for a plate (#980)

* LIMS-598: Show Anode maps if attached (#995)

* LIMS-1951: Fix link to Multi Crystal reprocessing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants