Skip to content

LIMS-1951: Fix reprocessing on Auto Processing Status Summary page #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ndg63276 merged 2 commits into from
Nov 11, 2025
Merged

LIMS-1951: Fix reprocessing on Auto Processing Status Summary page #996

ndg63276 merged 2 commits into from
Nov 11, 2025

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Oct 22, 2025

JIRA ticket: LIMS-1951

Summary:

The reprocessing button on eg https://ispyb.diamond.ac.uk/dc/apstatussummary/visit/cm40607-4 is broken.

Also not all pipeline results are always shown.

Changes:

  • Rename reprocess2.js to reprocess.js, discarding the original (broken) reprocess.js
  • Redirect anything using reprocess2.js to reprocess.js
  • Get the list of pipelines from all data collections on the page, not just the first one
  • Don't show a spinner if no results, just leave blank
  • Handle the scenario where a data collection was missing all downstream results

To test:

  • Use the production database, as reprocessing only works from there
  • Go to /dc/apstatussummary/visit/cm40607-4, check that there are columns for downstream pipelines (eg dimple), even though the first data collection doesn't have any downstream results
  • Go to page 5, check there are no errors in the console and no "spinners" are shown
  • Click the cog icon, and run a reprocessing job (fast_dp is fastest). Check it runs ok.

gfrn
gfrn reviewed Oct 28, 2025
View reviewed changes
@ndg63276 ndg63276 requested a review from gfrn October 28, 2025 16:10
@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R5.2 November 11, 2025 11:39
@ndg63276 ndg63276 merged commit 8a1117d into pre-release/2025-R5.2 Nov 11, 2025
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1951/fix-reprocessing-from-auto-processing-status-summary-page branch November 11, 2025 11:41
ndg63276 added a commit that referenced this pull request Nov 20, 2025
@ndg63276
Merge pre-release/2025-R5.2 into master (#1008)
e80bd1e 
* LIMS-1957: Fix fault report URLs for beamlines with hyphens (#997)

* LIMS-1952: Add select all button to multicrystal page (#999)

* LIMS-1951: Fix reprocessing on Auto Processing Status Summary page (#996)

* LIMS-1753: View of all inspection images for a plate (#980)

* LIMS-598: Show Anode maps if attached (#995)

* LIMS-1951: Fix link to Multi Crystal reprocessing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gfrn gfrn gfrn approved these changes

Assignees

No one assigned

Labels

Ready to Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndg63276 @gfrn