Skip to content

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1963

Summary:

If you go to ny27314 and try to add a new lab contact, Synchweb requests the list of users with logins. The backend says there are 54 but only returns the first 25. We should up the page size.

Changes:

  • Set page size as 9999

To test:

  • Log in as cog99989, go to proposal nt27314, then go to /contacts/add
  • Check there is a name in the Login dropdown
  • Check the dev console check the request to /api/users has per_page=9999, and that the total returned matches the number of rows in the data returned.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R5.1 October 28, 2025 11:26
@ndg63276 ndg63276 merged commit 0aa1820 into pre-release/2025-R5.1 Oct 28, 2025
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1963/load-all-logins-for-proposal branch October 28, 2025 11:28
ndg63276 added a commit that referenced this pull request Nov 11, 2025
* LIMS-1759: Add pages to create and view ligands (#957)

* LIMS-1759: Add pages to add/view/list ligands, add PDBS, and add to samples

* LIMS-1759: Add ligands to samples in plates

* LIMS-1759: Fix bug where ligands were added multiple times

* LIMS-1759: Fix error with too few args

---------

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1926: Hide barcode field when viewing a puck (#991)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1963: Load all logins for a proposal (#998)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1917: Track status of strategy pipelines (#993)

* LIMS-1917: Track status of strategy pipelines

* LIMS-1917: Hide strategy pipelines from downstream results

---------

Co-authored-by: Mark Williams <[email protected]>

---------

Co-authored-by: Mark Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants