Skip to content

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1952

Summary:

On the multicrystal reprocessing page (eg https://ispyb.diamond.ac.uk/mc/visit/cm40607-4 ) it would be good if each data collection had a select all images button next to it. Also fix a couple of minor bugs.

Changes:

  • Add a Select All button next to each data collection, to select all the images from that data collection
  • Don't allow fast_dp to run on more than one data collection
  • Don't display the "AP Cell" as "undefined, undefined" if autoprocessing failed
  • Clicking on the AP Cell should populate the space group as well as the cell parameters

To test:

  • Use the production database as reprocessing only works with prod
  • Go to a multicrystal reprocessing page (eg /mc/visit/cm40607-4), scroll to the bottom half of the page with the graphs
  • Check each data collection has an AP Cell set, or "N/A", not undefined,undefined etc
  • Check if you click on an AP Cell, the space group populates in the Reprocessing options row, not just the cell parameters
  • Check each data collection has a "Select All" button, and that clicking it highlights all images in the data collection
  • Click Select All on 2 data collections, choose Fast DP as the pipeline, and click Integrate. Check you get an error as Fast DP cannot do multiple sweeps
  • Change the pipeline to eg Xia2 Dials, and click Integrate. Check the job is submitted successfully and appears at the top of the page, correctly using all images from each selected data collection

@gfrn
Copy link
Collaborator

gfrn commented Oct 28, 2025

It wasn't immediately clear to me that AP cells were clickable, but it still works!

@ndg63276
Copy link
Collaborator Author

It wasn't immediately clear to me that AP cells were clickable, but it still works!

Yep, didn't know it either. Have added a cursor: pointer to make it look a bit more clickable.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R5.2 November 11, 2025 11:39
@ndg63276 ndg63276 merged commit a7b9c85 into pre-release/2025-R5.2 Nov 11, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1952/add-select-all-button-to-multicrystal branch November 11, 2025 11:41
ndg63276 added a commit that referenced this pull request Nov 20, 2025
* LIMS-1957: Fix fault report URLs for beamlines with hyphens (#997)

* LIMS-1952: Add select all button to multicrystal page (#999)

* LIMS-1951: Fix reprocessing on Auto Processing Status Summary page (#996)

* LIMS-1753: View of all inspection images for a plate (#980)

* LIMS-598: Show Anode maps if attached (#995)

* LIMS-1951: Fix link to Multi Crystal reprocessing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants