Skip to content

Run eslint checks on frontend code in CI #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yousefmoazzam wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Run eslint checks on frontend code in CI #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
261d593
Remove tools integrating prettier and eslint
yousefmoazzam Sep 9, 2025
6f2b166
Add prettier dev dependency
yousefmoazzam Sep 9, 2025
5ef4c46
Remove eslint rules relating to react package import
yousefmoazzam Sep 9, 2025
2c709a0
Add eslint rule for pattern to ignore unused var
yousefmoazzam Sep 9, 2025
3d29359
Add eslint step in frontend code CI
yousefmoazzam Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/_frontend_code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
- main

jobs:
lint:
code_checks:
runs-on: ubuntu-latest
steps:
- name: Checkout repository code
Expand All @@ -27,3 +27,7 @@ jobs:
- name: Check Formatting of TypeScript Code
working-directory: frontend
run: npm run format:check

- name: Check Linting Rules for TypeScript Code
working-directory: frontend
run: npm run lint
11 changes: 2 additions & 9 deletions frontend/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import reactHooks from "eslint-plugin-react-hooks";
import reactRefresh from "eslint-plugin-react-refresh";
import tseslint from "typescript-eslint";
import react from "eslint-plugin-react";
import prettier from "eslint-plugin-prettier";
import prettierConfig from "eslint-config-prettier";

export default tseslint.config(
{ ignores: ["dist"] },
Expand All @@ -25,27 +23,22 @@ export default tseslint.config(
"react-hooks": reactHooks,
"react-refresh": reactRefresh,
react,
prettier,
},
rules: {
...reactHooks.configs.recommended.rules,
"react-refresh/only-export-components": [
"warn",
{ allowConstantExport: true },
],
"react/react-in-jsx-scope": "off",
"react/jsx-uses-react": "off",
"prettier/prettier": "error",
"@typescript-eslint/no-unused-vars": [
"error",
{ argsIgnorePattern: "^_" },
{ argsIgnorePattern: "^_", varsIgnorePattern: "^_" },
],
},
settings: {
react: {
version: "detect",
},
},
},
prettierConfig
}
);
100 changes: 1 addition & 99 deletions frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,13 @@
"@types/relay-runtime": "^19.0.2",
"@vitejs/plugin-react": "^4.3.3",
"eslint": "^9.13.0",
"eslint-config-prettier": "^10.1.8",
"eslint-plugin-prettier": "^5.5.4",
"eslint-plugin-react": "^7.37.5",
"eslint-plugin-react-hooks": "^5.0.0",
"eslint-plugin-react-refresh": "^0.4.14",
"globals": "^15.11.0",
"husky": "^9.1.7",
"lint-staged": "^16.1.5",
"prettier": "^3.6.2",
"relay-compiler": "^20.0.0",
"typescript": "~5.6.2",
"typescript-eslint": "^8.11.0",
Expand Down
Loading