Skip to content

fix: Pin the system test containers #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DiamondJoseph merged 3 commits into from
Aug 4, 2025
Merged

fix: Pin the system test containers #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b47459a
fix: Temporarily pin the system test containers
DiamondJoseph Aug 1, 2025
77361c0
fix: Enable Renovate to automate pinned actions/checkout
DiamondJoseph Aug 1, 2025
36bf799
Merge branch 'main' into pin-system-tests
DiamondJoseph Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/_system_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
with:
repository: epics-containers/example-services
path: example-services
ref: '2025.8.1'

- name: Compose devices
uses: hoverkraft-tech/compose-action@40041ff1b97dbf152cd2361138c2b03fa29139df # v2.3.0
Expand Down
15 changes: 15 additions & 0 deletions renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,20 @@
],
"description": "Group non-major github action updates"
}
],
"customManagers": [
{
"customType": "regex",
"fileMatch": [
"^\\.github/workflows/[^/]+\\.ya?ml$"
],
"matchStringsStrategy": "combination",
"matchStrings": [
"uses: actions/checkout@v*\\s",
"repository: (?<depName>.*?)\\s",
"ref: (?<currentValue>.*?)\\s"
],
"datasourceTemplate": "github-tags"
Comment on lines +64 to +76
Copy link
Contributor Author

@DiamondJoseph DiamondJoseph Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cite: renovatebot/renovate#15857 (comment)

Copy link
Contributor

@ZohebShaikh ZohebShaikh Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be worth looking for a fileMatch of Dockerfile to ignore creating this type of PR

Copy link
Contributor Author

@DiamondJoseph DiamondJoseph Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe our Dockerfiles will stop having ARG of python version once we're using uv, which means we can then pin to the version of python we actually use for our build and the spurious PRs will be much reduced (along with uv better control of dependencies)

}
]
}