Skip to content

Conversation

@abbiemery
Copy link
Contributor

This is a change on top of this #1221 pr to see if using the pydantic models was better. I don't know about their support in the larger bluesky ecosystem to make any comment on their use here, but was worth playing with.

@abbiemery abbiemery requested a review from a team as a code owner October 20, 2025 17:01
@abbiemery abbiemery self-assigned this Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.69%. Comparing base (43bc037) to head (3ad51b9).

Additional details and impacted files
@@               Coverage Diff                @@
##           clear-start-doc    #1247   +/-   ##
================================================
  Coverage            94.69%   94.69%           
================================================
  Files                   41       41           
  Lines                 2619     2620    +1     
================================================
+ Hits                  2480     2481    +1     
  Misses                 139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abbiemery abbiemery changed the title Use pydantic event model for start and stop document handling refactor: Use pydantic event model for start and stop document handling Oct 20, 2025
@DiamondJoseph
Copy link
Contributor

Since we're almost immediately model_dumping the BaseModel and working with the arbitrary extra fields, our deserialisation doesn't appear to play nicely and it changes the behaviour of a null scan_id I think let's merge #1221 as is and leave this for now.

Base automatically changed from clear-start-doc to main October 22, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants