-
Notifications
You must be signed in to change notification settings - Fork 8
ci: Enforce Conventional Commit PR titles #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
=======================================
Coverage 94.42% 94.42%
=======================================
Files 40 40
Lines 2403 2403
=======================================
Hits 2269 2269
Misses 134 134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
If DiamondLightSource/python-copier-template#255 is merged upstream then we can just update the copier template rather than merge this, correct? |
|
No, the change to the python-copier-template only enables it for the copier template. Why do you not want to enforce squash-and-merge? It's already the default option for PRs in this repository and looking at the first page of the git history, it's always been used. |
callumforrester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to enforce it for blueapi, not for copier template projects, so all good. Should have a separate ADR here though.
callumforrester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I recommend drawing attention to this one in slack on merge, in the core team channel at least and possibly wider
See also: the proposed ADR in this PR
And how release-please was able to automate a release in this example repository.