Skip to content

Conversation

@DiamondJoseph
Copy link
Contributor

@DiamondJoseph DiamondJoseph commented Apr 14, 2025

See also: the proposed ADR in this PR

And how release-please was able to automate a release in this example repository.

@DiamondJoseph DiamondJoseph marked this pull request as ready for review April 14, 2025 10:13
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.42%. Comparing base (20e0377) to head (09d71f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #918   +/-   ##
=======================================
  Coverage   94.42%   94.42%           
=======================================
  Files          40       40           
  Lines        2403     2403           
=======================================
  Hits         2269     2269           
  Misses        134      134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@callumforrester
Copy link
Contributor

If DiamondLightSource/python-copier-template#255 is merged upstream then we can just update the copier template rather than merge this, correct?

@DiamondJoseph
Copy link
Contributor Author

DiamondJoseph commented Apr 14, 2025

No, the change to the python-copier-template only enables it for the copier template.

Why do you not want to enforce squash-and-merge? It's already the default option for PRs in this repository and looking at the first page of the git history, it's always been used.

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to enforce it for blueapi, not for copier template projects, so all good. Should have a separate ADR here though.

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I recommend drawing attention to this one in slack on merge, in the core team channel at least and possibly wider

@DiamondJoseph DiamondJoseph merged commit 6f55571 into main Apr 15, 2025
32 checks passed
@DiamondJoseph DiamondJoseph deleted the conventional-commits branch April 15, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants