Skip to content

Conversation

@Relm-Arrowny
Copy link
Collaborator

@Relm-Arrowny Relm-Arrowny commented May 20, 2025

Fixes #66

@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.63%. Comparing base (fc6b6f2) to head (3560c9f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   98.24%   98.63%   +0.38%     
==========================================
  Files           5        5              
  Lines          57       73      +16     
==========================================
+ Hits           56       72      +16     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Relm-Arrowny Relm-Arrowny marked this pull request as ready for review May 21, 2025 11:23
@olliesilvester olliesilvester self-assigned this May 21, 2025
Copy link
Collaborator

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just a few minor comments, happy to discuss if you disagree/they don't make sense

@olliesilvester olliesilvester changed the title add cache for client get Add caching for client get May 21, 2025
Copy link
Collaborator

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've made some more suggestions to try and keep the logic more simple

Copy link
Collaborator

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic + tests looks great now, thanks. I have some opinionated requests for some of the comments, then I will approve

Base automatically changed from 65_create_main_endpoint to main May 22, 2025 10:36
@Relm-Arrowny Relm-Arrowny linked an issue May 22, 2025 that may be closed by this pull request
…m:DiamondLightSource/daq-config-server into 66-implement-caching-on-get_configuration
Copy link
Collaborator

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will wait to resolve that conversation with @DiamondJoseph before merging

@Relm-Arrowny Relm-Arrowny merged commit 4791b34 into main May 22, 2025
16 checks passed
@Relm-Arrowny Relm-Arrowny deleted the 66-implement-caching-on-get_configuration branch May 22, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement caching on get_configuration

4 participants