Create script to build image and run container in dev mode #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliesilvester
changed the title
…ainer-in-dev-mode
olliesilvester
requested changes
May 29, 2025
Collaborator
olliesilvester
left a comment
olliesilvester
left a comment
There was a problem hiding this comment.
Thanks, this looks almost there. I haven't tried pushing it just yet, but a few comments first
…v-mode' of github.com:DiamondLightSource/daq-config-server into 84-create-script-to-build-image-and-run-container-in-dev-mode
olliesilvester
approved these changes
May 30, 2025
Collaborator
olliesilvester
left a comment
olliesilvester
left a comment
There was a problem hiding this comment.
Thanks, this works nicely now. Pushing won't work without an extra authentication step, but that's okay for now since CI safely pushes the image on release.
We should also document how to test using this script, but I will start on writing those early next week.
olliesilvester
deleted the
84-create-script-to-build-image-and-run-container-in-dev-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #84
Instructions to reviewer on how to test:
Checks for reviewer