Get typing support on client and do better exception handling #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliesilvester
commented
May 29, 2025
|
|
||
| from .constants import ENDPOINTS | ||
|
|
||
| T = TypeVar("T", str, bytes, dict[Any, Any]) |
Collaborator
Author
There was a problem hiding this comment.
Potential future change: make T unbounded so that the user can request a specific type of dict. The tradeoff is we'd the static check on whether get_file_contents was called with a supported type - it would be replaced with a runtime check.
Collaborator
Author
|
Let's ignore project codecov since patch is 100% |
Relm-Arrowny
requested changes
May 30, 2025
Collaborator
Relm-Arrowny
left a comment
Relm-Arrowny
left a comment
There was a problem hiding this comment.
Looks good, I spotted a couple of typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86 and #87
To test:
daq-config-serverin the devcontainerpytest ., and confirm both unit and system tests passConfigServer()client, callingget_file_contents(), and checking the static typing works as expected