Skip to content

Conversation

DominicOram
Copy link
Contributor

Fixes broken tests, issue was pytest-dev/pytest-asyncio#1106

Instructions to reviewer on how to test:

  1. Reinstall the dev environement
  2. Confirm tests pass on this branch but fail on main

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram DominicOram requested a review from a team as a code owner May 27, 2025 09:44
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (483b93d) to head (fdbb87f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1246   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files         199      199           
  Lines        7673     7673           
=======================================
  Hits         7518     7518           
  Misses        155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DominicOram DominicOram merged commit c1279dc into main May 27, 2025
22 checks passed
@DominicOram DominicOram deleted the fix_broken_tests branch May 27, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants