Skip to content

Conversation

@Villtord
Copy link
Contributor

@Villtord Villtord commented Oct 10, 2025

Fixes DiamondLightSource/sm-bluesky#179

K07 beamline does not exist yet, but we already know it is going to have an Apple2 class undulator device.

Instructions to reviewer on how to test:

  1. run tests
  2. Confirm pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.89%. Comparing base (dff7317) to head (f0bd998).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1624   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files         266      268    +2     
  Lines        9783     9811   +28     
=======================================
+ Hits         9675     9703   +28     
  Misses        108      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Villtord Villtord linked an issue Oct 10, 2025 that may be closed by this pull request
@Villtord Villtord marked this pull request as ready for review October 23, 2025 11:14
@Villtord Villtord requested a review from a team as a code owner October 23, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Apple2 ID for k07

3 participants