Remove unused dataclasses-json dependency #1662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbiemery
force-pushed
the
remove-dataclasses-json
branch
from
8b4100b to
9ce2d30
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1662 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 270 270
Lines 9888 9888
=======================================
Hits 9780 9780
Misses 108 108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DominicOram
approved these changes
Nov 18, 2025
Contributor
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
I see no reason not do to do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following dependencies are causing narrow dependency resolution up stream:
dodal-> dataclasses-json -> marshmallowdodal -> zocalo-> marshmallowdataclasses-jsondoesn't appear to still be used in dodal, it isn't imported anywhere afaik, so I suggest taking it out. Please do correct me if I am wrong.