Skip to content

Conversation

@Relm-Arrowny
Copy link
Contributor

@Relm-Arrowny Relm-Arrowny commented Oct 28, 2025

Fixes #1663

  • Implemented J09EnergyMotorLookup to enable energy lookup for the i09-2 ID (Insertion Device).
  • Introduced J09Apple2Controller to manage Apple II polarization and the conversion of energy to motor movement.
  • Refactored test setup by adding conftest.py to both i10 and i09_2_share folder to reuse fixtures.
  • Updated the i09_2 configuration to include devices for beam energy, ID energy, and polarization.

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Relm-Arrowny Relm-Arrowny linked an issue Oct 28, 2025 that may be closed by this pull request
10 tasks
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.09%. Comparing base (e2be4db) to head (bcc1815).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1672   +/-   ##
=======================================
  Coverage   99.08%   99.09%           
=======================================
  Files         275      276    +1     
  Lines       10099    10158   +59     
=======================================
+ Hits        10007    10066   +59     
  Misses         92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Relm-Arrowny Relm-Arrowny changed the base branch from main to create_apple2_energy_motor_lookUP October 29, 2025 14:48
Base automatically changed from create_apple2_energy_motor_lookUP to main November 13, 2025 15:57
@Relm-Arrowny Relm-Arrowny changed the base branch from main to id_lookup_config_improvements November 17, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i09-2 energy

2 participants