Skip to content

Conversation

@Villtord
Copy link
Contributor

@Villtord Villtord commented Nov 14, 2025

Fixes DiamondLightSource/sm-bluesky#157

Instructions to reviewer on how to test:

  1. Connect beamline
  2. Tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.09%. Comparing base (2b7fa79) to head (c81366a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1713   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         275      276    +1     
  Lines       10129    10182   +53     
=======================================
+ Hits        10037    10090   +53     
  Misses         92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Villtord Villtord self-assigned this Nov 14, 2025
@Villtord Villtord linked an issue Nov 20, 2025 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure I09-1-shared Hard-X-Ray ID

2 participants