Skip to content

Conversation

@olliesilvester
Copy link
Collaborator

Part of DiamondLightSource/mx-bluesky#1471

If the expected energy is None, we should use the current energy instead.

Typing should have caught this issue, but we had it disabled for the whole file - we disabled it because old ophyd-devices don't play nicely with typing. I've added individual type ignores instead so that real typing errors still get noticed.

@olliesilvester olliesilvester requested a review from a team as a code owner November 26, 2025 14:33
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (9435d9e) to head (d2a31fc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1737   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         281      281           
  Lines       10665    10667    +2     
=======================================
+ Hits        10571    10573    +2     
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@olliesilvester olliesilvester merged commit a2e9629 into main Dec 16, 2025
11 checks passed
@olliesilvester olliesilvester deleted the fix_eiger_typing branch December 16, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants