Skip to content

Conversation

@DiamondJoseph
Copy link
Contributor

Removes the pre-release requirement on the daq-config-server:- 1.0.0 was released earlier from the same commit as 1.0.0-rc2, and uv does not like dependencies with pre-release tags without being explicitly told they are allowed.

Therefore, this will cause issues in all projects that update to the copier template 5.0.0

Instructions to reviewer on how to test:

  1. Confirm that tests still pass and uv sync can be used on projects

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DiamondJoseph DiamondJoseph requested a review from a team as a code owner December 4, 2025 17:08
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (e960403) to head (b7169b5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1758   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         281      281           
  Lines       10665    10665           
=======================================
  Hits        10571    10571           
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DominicOram DominicOram enabled auto-merge (squash) December 8, 2025 17:20
@DominicOram DominicOram merged commit 9435d9e into main Dec 16, 2025
10 checks passed
@DominicOram DominicOram deleted the released-daq-config-server branch December 16, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants