Changes to support hyperion-supervisor #1804
Conversation
rtuck99
changed the base branch from
main
to
mx-bluesky_1364_fix_generic_params_in_robot_protocol
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1804 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 288 289 +1
Lines 10957 10970 +13
=======================================
+ Hits 10863 10876 +13
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -0,0 +1,19 @@ | |||
| from dodal.common.beamlines.beamline_utils import set_beamline as set_utils_beamline | |||
There was a problem hiding this comment.
What's the purpose of having the supervisor as a beamline seperate to i03? Is this so you can dodal connect i03_supervisor to just get the baton?
There was a problem hiding this comment.
The supervisor beamline is loaded into the bluesky context inside the hyperion-supervisor process. It only needs to access the baton as all the devices are interacted with by the hyperion-blueapi blueapi instance.
I think it's cleaner to do it this way rather than loading the main i03 beamline and disabling all the other devices through some special flag, loading i03.py is also quite heavyweight due to all the other things it imports.
rtuck99
force-pushed
the
mx-bluesky_supervisor
branch
from
a6d7846 to
46380d0
Compare
Required to address
Requires
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}