Skip to content

Conversation

@olliesilvester
Copy link
Collaborator

Fixes DiamondLightSource/mx-bluesky#1594

Fixes this by replacing the previous logic with a sleep. This sleep can be removed once https://jira.diamond.ac.uk/browse/I04-1100 is done

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@olliesilvester olliesilvester requested a review from a team as a code owner February 4, 2026 11:27
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (07c1416) to head (7999d4a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1885      +/-   ##
==========================================
- Coverage   99.14%   99.14%   -0.01%     
==========================================
  Files         304      304              
  Lines       11509    11508       -1     
==========================================
- Hits        11411    11410       -1     
  Misses         98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jacob720 jacob720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just fix lint

@olliesilvester olliesilvester merged commit 111ce25 into main Feb 4, 2026
10 checks passed
@olliesilvester olliesilvester deleted the mx_bluesky_1594_fix_transfocator branch February 4, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate i04's transfocator timeout during XRC

2 participants