Skip to content

Add detector id on jungfrau#1931

Merged
olliesilvester merged 5 commits intomainfrom
i24_use_numtracker
Feb 26, 2026
Merged

Add detector id on jungfrau#1931
olliesilvester merged 5 commits intomainfrom
i24_use_numtracker

Conversation

@olliesilvester
Copy link
Collaborator

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@olliesilvester olliesilvester requested a review from a team as a code owner February 19, 2026 16:35
@olliesilvester olliesilvester changed the title Remove test path provider for i24 Add detector id on jungfrau Feb 19, 2026
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (fa0d70d) to head (5a539a9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1931   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         314      314           
  Lines       11778    11779    +1     
=======================================
+ Hits        11667    11668    +1     
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jacob720 jacob720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@olliesilvester olliesilvester enabled auto-merge (squash) February 26, 2026 11:20
@olliesilvester olliesilvester merged commit 178425f into main Feb 26, 2026
7 checks passed
@olliesilvester olliesilvester deleted the i24_use_numtracker branch February 26, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants