-
Notifications
You must be signed in to change notification settings - Fork 2
Use multistage built for container #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
=======================================
Coverage 49.27% 49.27%
=======================================
Files 13 13
Lines 621 621
=======================================
Hits 306 306
Misses 315 315 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tpoliaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, How does the caching using --mount=type=cache... work with the GHA level caching? Are both still needed?
|
There was also some discussion about whether having a full OS environment was useful for debugging |
|
Should we publish two sets of images
This will help to make the production builds to deployed faster without adding much overhead. For the previous question about cache. They are 2 different cache there
|
|
After offline discussion, It was decided that using alpine image (3.7 MB) as the final build is better than scratch as it gives us BusyBox,shell,vi,.. which is useful for debugging. |
Now: 13MB(scratch)Now: 21MB with alpine as final base image)