-
Notifications
You must be signed in to change notification settings - Fork 2
Add resolvers to get details of specific runs #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 51.00% 49.27% -1.73%
==========================================
Files 13 13
Lines 600 621 +21
==========================================
Hits 306 306
- Misses 294 315 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like being able to look at one run, but now if you use the instrument session query you have both run and runs as a field option. Is this what you expected? While it became quickly apparent what is was for after graphiql shouted at me, it felt a bit confusing on the face of it. I don't have an opinion yet on how i'd want this to feel, but I thought i'd mention it.

Also, in my data I actually have two scans with different run_id's but the same scan number. This change only grabs one of them, not sure how it decides which. While in the world of production we keep track of these numbers to avoid clashes, anyone messing about in the weeds with our stack (Im thinking training rigs) may have this happen too. I think the choices are: return both things, Or specify on run _id instead. It's nicer for the user to be able to avoid uuid's but then we have a ui that isn't consistent.
Yes, one gets a single run, the other gets all the runs. Open to better naming ideas.
The first one returned by tiled. The problem with returning all matching scans is that you either have to always return a list when in the vast majority of cases with real data you're only going to get a single result, or have a flexible schema where you have to handle both cases which is a pain.
If the user has the run_id they don't need to go via the instrument_session, they can access the run directly via the |
3b02fc0 to
f759adb
Compare
On the instrumentSession object, run takes a scan number as these should be unique within a session. On the root, it takes a run id as these should be unique across tiled.
f759adb to
04a90ed
Compare
9819837 to
96e64d7
Compare
abbiemery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think this is better like this with instrument session only having runs. Going forward we should enable runs to take arguments to filter on.
On the instrumentSession object, run takes a scan number as these should
be unique within a session. On the root, it takes a run id as these
should be unique across tiled.