-
Notifications
You must be signed in to change notification settings - Fork 2
Template 404 page to account for public_address #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 49.27% 48.80% -0.48%
==========================================
Files 13 13
Lines 621 627 +6
==========================================
Hits 306 306
- Misses 315 321 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
de566a5 to
b37a7af
Compare
If the service is not hosted at the root of a domain, the links to the graphql and graphiql endpoints cannot be absolute.
Bit of an overkill for two urls
|
I have checked that it does not working for localhost case as it tries to redirect me to "127.0.0.1/" (which does mean localhost) You can try this by doing You can also check at https://p46-blueapi.diamond.ac.uk/glazed/ |
|
The problem is that by default it binds to Potential fixes
Oddly, if I try to run with this PR but no config, clicking the link gives me an error |
I don't think the p46 version has this change (or if it does, the public address needs a trailing |
|
We need the |
If the service is not hosted at the root of a domain, the links to the
graphql and graphiql endpoints cannot be absolute.