Skip to content

Conversation

@jacob720
Copy link
Contributor

@jacob720 jacob720 commented Dec 5, 2025

Fixes #1494

Link to dodal PR (if required): DiamondLightSource/dodal#1768
Reads UndulatorDCM config through the config server.

Instructions to reviewer on how to test:

  1. Check tests pass

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@jacob720 jacob720 requested a review from a team as a code owner December 5, 2025 10:29
@jacob720 jacob720 marked this pull request as draft December 5, 2025 10:58
@jacob720 jacob720 force-pushed the use_daq_config_server branch from c4613e8 to 7c21294 Compare December 5, 2025 11:00
@jacob720 jacob720 added dev experience Changes relating to developer experience i03 Changes relating to I03 labels Dec 5, 2025
@jacob720 jacob720 force-pushed the use_daq_config_server branch from 7c21294 to 0ec62f4 Compare December 9, 2025 09:07
@jacob720 jacob720 removed the i03 Changes relating to I03 label Dec 10, 2025
@jacob720 jacob720 marked this pull request as ready for review January 12, 2026 13:27
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.32%. Comparing base (83de359) to head (a66a068).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1497   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         143      143           
  Lines        8126     8131    +5     
=======================================
+ Hits         7502     7507    +5     
  Misses        624      624           
Components Coverage Δ
i24 SSX 78.56% <ø> (ø)
hyperion 97.95% <100.00%> (+<0.01%) ⬆️
other 98.09% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Changes relating to developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Undulator and UndulatorDCM config to use the daq config server

2 participants