Skip to content

Conversation

@rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Jan 8, 2026

This addresses the hyperion portion of

This requires:

Link to dodal PR (if required): #N/A
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

  • Stomp support is now enabled in the callbacks when running hyperion-blueapi mode when the external callbacks are passed the --stomp-config parameter specifying a blueapi config file which contains the stomp configuration

Instructions to reviewer on how to test:

  • System tests require the rabbitmq-stomp container from the latest hyperion-system-test

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@rtuck99 rtuck99 added the dev experience Changes relating to developer experience label Jan 8, 2026
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 95.60440% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.72%. Comparing base (039028b) to head (f72d1f4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1535      +/-   ##
==========================================
+ Coverage   92.65%   92.72%   +0.06%     
==========================================
  Files         151      152       +1     
  Lines        8433     8499      +66     
==========================================
+ Hits         7814     7881      +67     
+ Misses        619      618       -1     
Components Coverage Δ
i24 SSX 78.56% <ø> (ø)
hyperion 98.20% <95.60%> (+0.09%) ⬆️
other 98.27% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 marked this pull request as ready for review January 8, 2026 14:41
@rtuck99 rtuck99 requested a review from a team as a code owner January 8, 2026 14:41
@DominicOram DominicOram self-requested a review January 12, 2026 11:36
@rtuck99 rtuck99 force-pushed the hyperion-supervisor branch from 60a3bdd to e80df89 Compare January 15, 2026 15:19
Base automatically changed from hyperion-supervisor to main January 15, 2026 15:50
@rtuck99 rtuck99 force-pushed the external_callbacks_via_stomp branch from 8b272ee to 4cdf50e Compare January 19, 2026 12:04
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I haven't had a chance to run the system tests. Couple of comments in code but mostly future looking stuff. Additionally, the config says we're trying to connect to stomp at tcp://localhost:61613, do we have to run this up ourselves? Or is this the GDA activeMQ that is already running? Can we add the answer to https://diamondlightsource.github.io/mx-bluesky/main/developer/hyperion/hyperion-blueapi.html?

BLUEAPI_EVENT_TOPIC = "public.worker.event"


class StompDispatcher(Dispatcher):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could: This seems generic enough that it should live in stomp-bluesky can you make a PR in there for it? Or at least an issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an outstanding issue DiamondLightSource/bluesky-stomp#14 - I've referenced this PR in it.

Unfortunately this file would introduce a circular dependency between stomp-bluesky and blueapi if introduced there.


from mx_bluesky.common.utils.log import ISPYB_ZOCALO_CALLBACK_LOGGER as LOGGER

BLUEAPI_EVENT_TOPIC = "public.worker.event"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should: Feels like we should get this out of blueapi somewhere, can you add an issue/PR to expose it in blueapi?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rtuck99 rtuck99 requested a review from DominicOram January 19, 2026 12:55
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I still think this needs the docs I suggested though

@DominicOram DominicOram enabled auto-merge (squash) January 19, 2026 14:12
@DominicOram DominicOram merged commit a645fb3 into main Jan 19, 2026
14 of 15 checks passed
@DominicOram DominicOram deleted the external_callbacks_via_stomp branch January 19, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Changes relating to developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants