Use protocols instead of smargon type for FGS composite, rename smargon to gonio#1619
Merged
olliesilvester merged 13 commits intomainfrom Feb 11, 2026
Merged
Use protocols instead of smargon type for FGS composite, rename smargon to gonio#1619olliesilvester merged 13 commits intomainfrom
olliesilvester merged 13 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1619 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 153 153
Lines 8632 8638 +6
=======================================
+ Hits 8015 8021 +6
Misses 617 617
🚀 New features to boost your workflow:
|
…ightSource/mx-bluesky into fgs_switch_smargon_for_protocol
jacob720
approved these changes
Feb 11, 2026
| omega: Motor | ||
|
|
||
|
|
||
| MotorWithOmegaType = TypeVar("MotorWithOmegaType", bound=GonioWithOmega) |
Contributor
There was a problem hiding this comment.
Is there a reason this isn't called GonioWithOmegaType?
Contributor
Author
There was a problem hiding this comment.
Not really, I will rename
olliesilvester
changed the title
adaudon
pushed a commit
that referenced
this pull request
Feb 13, 2026
* Use protocols instead of smargon type for FGS composite * Rename devices to gonio in all plans * Include generic type everywhere in plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1620
We should start doing this sort of thing for all our plan types. This one is useful for vmxm as their gonio has no Y stage, so we can't use the previous typing.
Link to dodal PR: DiamondLightSource/dodal#1908
Instructions to reviewer on how to test:
Checks for reviewer