Skip to content

Fix dlstbx and dodal environment in devcontainer#1621

Merged
olliesilvester merged 3 commits intomainfrom
improve_devcontainer
Feb 9, 2026
Merged

Fix dlstbx and dodal environment in devcontainer#1621
olliesilvester merged 3 commits intomainfrom
improve_devcontainer

Conversation

@olliesilvester
Copy link
Contributor

Since the coper update, the devcontainer didn't install dodal as an editable dependency. dlstbx also wasn't being put into the python environment correctly. This fixes both

To test:

  • Confirm that dodal is now an editable install after creating the devcontainer by typing uv pip freeze | grep dodal and seeing the -e flag
  • Confirm that the dlstbx tests now run in the dev container environment, eg test_nexus_file_validity_for_zocalo_with_two_linked_datasets

@olliesilvester olliesilvester requested a review from a team as a code owner February 9, 2026 14:00
@olliesilvester olliesilvester added the dev experience Changes relating to developer experience label Feb 9, 2026
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.85%. Comparing base (c69f4ee) to head (84af34b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1621   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files         153      153           
  Lines        8632     8632           
=======================================
  Hits         8015     8015           
  Misses        617      617           
Components Coverage Δ
i24 SSX 78.60% <ø> (ø)
hyperion 98.22% <ø> (ø)
other 98.32% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@adaudon adaudon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@olliesilvester olliesilvester merged commit 3286d6c into main Feb 9, 2026
28 of 29 checks passed
@olliesilvester olliesilvester deleted the improve_devcontainer branch February 9, 2026 17:36
adaudon pushed a commit that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Changes relating to developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants