Add CI checks as github actions #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpoliaw
force-pushed
the
ci
branch
4 times, most recently
from
dc7271a to
127604a
Compare
tpoliaw
force-pushed
the
ci
branch
2 times, most recently
from
1ec6f38 to
1e0b8d5
Compare
tpoliaw
force-pushed
the
ci
branch
4 times, most recently
from
0a6f834 to
5651505
Compare
callumforrester
approved these changes
Nov 29, 2024
Contributor
callumforrester
left a comment
callumforrester
left a comment
There was a problem hiding this comment.
LGTM, only a few minor comments
| @@ -0,0 +1,58 @@ | |||
| name: Numtracker CI | |||
Contributor
There was a problem hiding this comment.
Out of scope but can we decide if this project is called "numtracker" or "data endpoint lookup" and sort out all the references in this repo. Not opinionated on the verdict.
Collaborator
Author
There was a problem hiding this comment.
I don't think either name really says what it does and numtracker was shorter. Agree there should probably only be one name though.
On PRs, run * Check formatting * Check clippy lints * Build everything * Run tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.