Split format and clippy into separate CI jobs #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve CI performance by making cache more effective. The format check requires a nightly toolchain to support unstable formatting options but does not need to compile anything - this means the cache doesn't really affect the runtime and can be skipped. The clippy job needs to compile the project and therefore needs all the dependencies available. The cache uses the version of rust as part of the key so a nightly build guarantees a cache miss for the first job each day. Using the stable toolchain for the clippy check allows it to use the same cache from previous runs reducing the need to download crates twice for each PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve CI performance by making cache more effective.
The format check requires a nightly toolchain to support unstable
formatting options but does not need to compile anything - this means
the cache doesn't really affect the runtime and can be skipped.
The clippy job needs to compile the project and therefore needs all the
dependencies available.
The cache uses the version of rust as part of the key so a nightly build
guarantees a cache miss for the first job each day. Using the stable
toolchain for the clippy check allows it to use the same cache from
previous runs reducing the need to download crates twice for each PR.