Skip to content

Conversation

@gfrn
Copy link
Collaborator

@gfrn gfrn commented Sep 18, 2025

JIRA ticket: [LIMS-1761][(https://jira.diamond.ac.uk/browse/LIMS-1761)

Summary:

To further improve 3D classification models, users should be able to provide a low-res initial model to act as a starting point for building these classes.

This allows users to upload initial models which are dropped in the visit folder.

Changes:

  • Add initial model uploads

To test:

Assuming you've mounted /dls and you're using the local development DB. Make sure you delete the files you've uploaded from the visit folder of the visit you're using afterwards

You can use ispyb-restore too, just use a current EM visit (like bi34108-28)

  • Send a POST request to /proposals/cm31111/sessions/5/initialModel with image.mrc.zip as the body (unzipped), check if the image is deposited in the visit directory for cm31111-5
  • Send a POST request to /proposals/cm31111/sessions/5/initialModel with broken.mrc.zip as the body (unzipped), check if a 415 is returned (invalid file type)
  • Send a POST request to /proposals/cm31111/sessions/5/initialModel with any non-MRC file, check if 415 is returned

@gfrn gfrn self-assigned this Sep 18, 2025
@gfrn gfrn added the enhancement New feature or request label Sep 18, 2025
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.78%. Comparing base (63a7044) to head (5c5af86).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   94.71%   94.78%   +0.07%     
==========================================
  Files          46       46              
  Lines        1834     1859      +25     
==========================================
+ Hits         1737     1762      +25     
  Misses         97       97              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@RichB-DLS RichB-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to test locally due to dls mount issues but @gfrn has had this in use on staging for approx 2wks.

@gfrn gfrn merged commit 2e2885a into master Oct 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants