Skip to content

Conversation

@gfrn
Copy link
Collaborator

@gfrn gfrn commented Nov 11, 2025

JIRA ticket: LIMS-1966

Requires #18

Summary:

Add "alignment" and "stack" movie types to allow more image types to be returned from database

Changes:

  • Include more movie types

To test:

Assuming you're connected to ispyb-restore, and you have /dls mounted locally:

  • Make a GET request to https://local-oidc-test.diamond.ac.uk:9000/api/tomograms/155826/centralSlice?movieType=alignment, check if you get a tomogram alignment central slice
  • Make a GET request to https://local-oidc-test.diamond.ac.uk:9000/api/tomograms/155826/centralSlice?movieType=stack, check if you get a tomogram stack central slice
  • Make a GET request to https://local-oidc-test.diamond.ac.uk:9000/api/tomograms/155826/movie?movieType=stack, check if you get a tomogram stack movie (APNG)

@gfrn gfrn requested review from MattPrit and RichB-DLS November 11, 2025 10:38
@gfrn gfrn self-assigned this Nov 11, 2025
@gfrn gfrn added the enhancement New feature or request label Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.83%. Comparing base (615a0a9) to head (0bf197c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   94.78%   94.83%   +0.04%     
==========================================
  Files          46       46              
  Lines        1860     1858       -2     
==========================================
- Hits         1763     1762       -1     
+ Misses         97       96       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ew' into feature/lims-1966/display-aligned-stacks
@gfrn gfrn merged commit 4549579 into master Nov 13, 2025
12 checks passed
@gfrn gfrn deleted the feature/lims-1966/display-aligned-stacks branch November 13, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants