Skip to content

[LIMS-1700] Make classification values optional#2

Merged
gfrn merged 4 commits intomasterfrom
fix/lims-1700/classification-values-optional
May 2, 2025
Merged

[LIMS-1700] Make classification values optional#2
gfrn merged 4 commits intomasterfrom
fix/lims-1700/classification-values-optional

Conversation

@gfrn
Copy link
Collaborator

@gfrn gfrn commented Apr 23, 2025

JIRA ticket: LIMS-1700

Summary:

Since sometimes the pipeline fails to insert fourier completeness or estimated resolution values, we must consider these optional instead of throwing errors.

Changes:

  • Make fourier completeness, estimated resolution, rotation and translation accuracy optional in classification data endpoint
  • Check if movie is valid before returning movie information

To test:

@gfrn gfrn added the bug Something isn't working label Apr 23, 2025
@gfrn gfrn self-assigned this Apr 23, 2025
@codecov
Copy link

codecov bot commented Apr 23, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@gfrn gfrn requested review from MattPrit, RichB-DLS and ndg63276 April 24, 2025 14:08
Copy link
Collaborator

@MattPrit MattPrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfrn gfrn merged commit dd39927 into master May 2, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants