Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 94.39% 94.45% +0.05%
==========================================
Files 42 43 +1
Lines 1783 1784 +1
==========================================
+ Hits 1683 1685 +2
+ Misses 100 99 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…industrial-visits
MattPrit
reviewed
May 15, 2025
…:DiamondLightSource/pato-backend into feature/lims-1698/hide-industrial-visits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1698
Note: I've merged
feature/lims-1707/heatmapinto this branch by accident, it will include changes from both branchesSummary:
To prevent unwanted data access, this pull request adds the option to limit access to visits/proposals to those who are directly listed as part of that visit/proposal, and no one else (including staff).
Changes:
users_only_on_industrial)To test:
/autoProc/99498883/ctf) and ensure 404 is returned/proposals?search=in, check if no industry proposals are returned (prefixed byic,il,sworin)/sessions?proposal=in1, check if no sessions are returned