[LIMS-1670] Display Diamond logo properly in emails#5
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5 +/- ##
=========================================
Coverage ? 94.40%
=========================================
Files ? 43
Lines ? 1787
Branches ? 0
=========================================
Hits ? 1687
Misses ? 100
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MattPrit
requested changes
May 9, 2025
Co-authored-by: Matthew Pritchard <46708056+MattPrit@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1670
Summary:
Previously, the Diamond logo was included in headers as a SVG. This was not displayed in all email clients, so in order to improve compatibility, a PNG is attached instead.
Changes:
To test:
/dataGroups/988855/alerts, with{"email": "test@diamond.ac.uk"}as the body. Ensure an email is sent to that address, and that the email looks like this: