233 strict typing #238
Merged
233 strict typing #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add an option to the template to enable strict mode if pyright is selected as the type checker. - Default to standard type checking, the user must actively select it - Set config to strict if the user selects both pyright and strict mode (we do not support mypy strict mode) - Modify tests, remove "manual" enabling of strict mode now the template can do it for us
callumforrester
force-pushed
the
233-strict-typing
branch
from
adfd062 to
46b04eb
Compare
GDYendell
reviewed
Mar 14, 2025
Contributor
GDYendell
left a comment
GDYendell
left a comment
There was a problem hiding this comment.
Looks good to me except one typo. I support the default behaviour change.
coretl
previously approved these changes
Mar 14, 2025
Update docs on strict mode with more explanation of when to/not to use it. Include link in template prompt.
Set the default state of the template to pyright with strict mode, the user must conciously disable it. This is in line with the recommended approach in the docs of using strict mode fro new projects if practical.
callumforrester
force-pushed
the
233-strict-typing
branch
from
46b04eb to
6372ae3
Compare
GDYendell
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233