-
Notifications
You must be signed in to change notification settings - Fork 9
Add debugpy to Dockerfile for service containers #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
02cdb19
Add debugpy to Dockerfile for service containers
f9b1176
Add ADR
f8ac5ef
Add docs for creating Helm resources
3e9133c
Move Helm chart
8490124
Run Helm job when tagged
d06a87a
Linting and test fixes
842fd63
Do not try and lint yaml files in Helm templates
b86e1a1
Fix Helm action
75fb307
Checkout chart before linting it
96cdd92
Add Helm chart
41d7154
Add debugging to the pre-generated Helm chart
c1dac1d
Finish Helm?
e5f9481
Configure pre-commit to ignore Helm templates
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # 20. Add debugpy to service Dockerfile | ||
|
|
||
| Date: 2025-03-18 | ||
|
|
||
| ## Status | ||
|
|
||
| Accepted | ||
|
|
||
| ## Context | ||
|
|
||
| Developers require a way to debug containerized services in e.g. Kubernetes. | ||
|
|
||
| ## Decision | ||
|
|
||
| Add debugpy to the container image that is produced for services. | ||
|
|
||
| ## Consequences | ||
|
|
||
| Debugging containerized services has a clear and documented path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're at this, should we remove
--versionas the default use of the container is far more likely to be "run the cli", not "check the version of the cli"?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote to leave the Dockerfile as something that exits successfully and make it obvious how to modify it.