Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
93d1b55
Make pypi, release depend on test
dan-fernandes Apr 10, 2025
b7f2a2c
Split container build and push into two jobs
dan-fernandes Apr 10, 2025
55901ed
Add call to _push_container.yml in ci.yml.jinja
dan-fernandes Apr 10, 2025
fcdb8b2
Move _push_container.yml out of template, add symlink to new location
dan-fernandes Apr 11, 2025
39adf2c
Fix key name, fix file path
dan-fernandes Apr 11, 2025
7cdac25
Add ref_type=tag condition to push container
dan-fernandes Apr 11, 2025
2cdd018
Seperate _docs into _push_docs, add symlink
dan-fernandes Apr 11, 2025
f262aa5
Add repo checkout to _push_docs.yml
dan-fernandes Apr 14, 2025
7a7a0a6
Remove duplicate code
dan-fernandes Apr 15, 2025
51ae06a
Add _push_docs.yml to ci and tempalte ci
dan-fernandes Apr 15, 2025
9168714
Remove uneccesary wait
dan-fernandes Apr 15, 2025
78aa8bd
Fix referenced SHA
dan-fernandes Apr 15, 2025
9ff5d03
Merge 241-release-pipeline-does-not-depend-on-tests branch from fork …
dan-fernandes Apr 15, 2025
307414e
Have _push_docs call depend on test
dan-fernandes Apr 16, 2025
c2060f7
Make release depend on test
dan-fernandes Apr 16, 2025
7894539
Rename _push_docs job to publish
dan-fernandes Apr 16, 2025
6d9dff8
Move _push_docs condition into ci
dan-fernandes Apr 16, 2025
80178a8
Add Load Image step
dan-fernandes Apr 16, 2025
816687c
Remove load from build-push-action
dan-fernandes Apr 16, 2025
0788359
Remove context
dan-fernandes Apr 16, 2025
ad03418
Make both _container.yml and _push_container.yml build and test conta…
dan-fernandes Apr 30, 2025
965f51f
Make both _docs.yml and _push_docs.yml build docs
dan-fernandes Apr 30, 2025
67b49d7
Re-add removed load attribute
dan-fernandes Apr 30, 2025
0d09bb2
Remove output parameter to container build
dan-fernandes May 1, 2025
85d1671
Remove document artifact upload in _push_docs to avoid duplicate arti…
dan-fernandes May 1, 2025
feb4bc1
Remove all _push_container.yml and _push_docs.yml
dan-fernandes May 7, 2025
87f2f36
Add pushing back into _container conditional on needs.test.result
dan-fernandes May 7, 2025
9ed4d31
Add pushing back into _docs.yml conditional on needs.test.result
dan-fernandes May 7, 2025
d13e5ce
Remove _push_docs.yml reference in ci
dan-fernandes May 7, 2025
2e9f1fa
Make docs, container workflows need test workflow
dan-fernandes May 7, 2025
6a402b1
Fix conditional on pypi, release and dist workflows to rely on tests…
dan-fernandes May 7, 2025
ad37180
Fix broken needs.test conditionals
dan-fernandes May 8, 2025
78fa020
Add publish input to _docs.yml
dan-fernandes May 8, 2025
f8e15cd
Add publish input to _container.yml
dan-fernandes May 8, 2025
88f18ac
Fix publish input description
dan-fernandes May 8, 2025
2d66438
Add test to dist.needs
dan-fernandes May 8, 2025
92866d9
Remove test from pypi.needs
dan-fernandes May 8, 2025
fa59429
Ammend pypi.if to require dist result success
dan-fernandes May 8, 2025
80be825
Remove dist.needs.test, add pypi.needs.test
dan-fernandes May 8, 2025
18efa67
Add needs.test.result to pypi conditional
dan-fernandes May 8, 2025
60dec89
Standardise order of needs/if
dan-fernandes May 8, 2025
82acbe5
Add needs.dist.result success to release conditional
dan-fernandes May 8, 2025
acb8f6d
Add always() to docs conditional
dan-fernandes May 8, 2025
aac4043
Remove uneccesary needs.*.result from conditionals
dan-fernandes May 8, 2025
d39ee6f
Add always() to docs and container conditionals
dan-fernandes May 8, 2025
319c71a
Replace needs with jobs in conditionals
dan-fernandes May 8, 2025
a86f8c2
Revert "Replace needs with jobs in conditionals"
dan-fernandes May 8, 2025
a79e6e6
Add raw tags around blocks with gh action expressions
dan-fernandes May 8, 2025
363b5ab
Merge branch 'main' into 241-release-pipeline-does-not-depend-on-tests
dan-fernandes May 19, 2025
58dccf7
Update ci.yml to remove depricated check depenency
dan-fernandes May 19, 2025
9b0a62b
Remove docs workflow need test workflow
dan-fernandes Jun 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/_container.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
on:
workflow_call:
inputs:
publish:
type: boolean
description: If true, pushes image to container registry

jobs:
build:
Expand Down Expand Up @@ -47,7 +51,7 @@ jobs:
type=raw,value=latest

- name: Push cached image to container registry
if: github.ref_type == 'tag'
if: inputs.publish && github.ref_type == 'tag'
uses: docker/build-push-action@v6
env:
DOCKER_BUILD_RECORD_UPLOAD: false
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/_docs.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
on:
workflow_call:
inputs:
publish:
type: boolean
description: If true, publishes docs to gh-pages


jobs:
build:
Expand Down Expand Up @@ -44,7 +49,7 @@ jobs:
run: python .github/pages/make_switcher.py --add $DOCS_VERSION ${{ github.repository }} .github/pages/switcher.json

- name: Publish Docs to gh-pages
if: github.ref_type == 'tag' || github.ref_name == 'main'
if: inputs.publish && (github.ref_type == 'tag' || github.ref_name == 'main')
# We pin to the SHA, not the tag, for security reasons.
# https://docs.github.com/en/actions/learn-github-actions/security-hardening-for-github-actions#using-third-party-actions
uses: peaceiris/actions-gh-pages@4f9cc6602d3f66b9c108549d475ec49e8ef4d45e # v4.0.0
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ jobs:

docs:
uses: ./.github/workflows/_docs.yml
with:
publish: ${{needs.test.result == 'success'}}
permissions:
contents: write

Expand All @@ -35,8 +37,8 @@ jobs:
EXAMPLE_DEPLOY_KEY: ${{ secrets.EXAMPLE_DEPLOY_KEY }}

release:
needs: [test, docs]
if: github.ref_type == 'tag'
needs: docs
uses: ./.github/workflows/_release.yml
permissions:
contents: write
Original file line number Diff line number Diff line change
Expand Up @@ -27,29 +27,36 @@ jobs:
python-version: ${{ matrix.python-version }}
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
{% endraw %}{% if docker %}
{% endraw %}{% if docker %}{% raw %}
container:
needs: test
if: always()
uses: ./.github/workflows/_container.yml
with:
publish: ${{ needs.test.result == 'success' }}
permissions:
contents: read
packages: write
{% endif %}{% if sphinx %}
{% endraw %}{% endif %}{% if sphinx %}{% raw %}
docs:
uses: ./.github/workflows/_docs.yml
{% endif %}
with:
publish: ${{ needs.test.result == 'success' }}

{% endraw %}{% endif %}
dist:
uses: ./.github/workflows/_dist.yml
{% if pypi %}
pypi:
needs: [dist, test]
if: github.ref_type == 'tag'
needs: dist
uses: ./.github/workflows/_pypi.yml
permissions:
id-token: write
{% endif %}
release:
needs: [dist, test{% if sphinx %}, docs{% endif %}]
if: github.ref_type == 'tag'
needs: [dist{% if sphinx %}, docs{% endif %}]
uses: ./.github/workflows/_release.yml
permissions:
contents: write