-
Notifications
You must be signed in to change notification settings - Fork 9
fix!: Remove need for --trust #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There are still two instances of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me.
We should explicitly get the user to do the unsafe stuff and not have any tasks if we can avoid it.
I could also change the ioc-template to do the same thing.
@DiamondJoseph there is one wrinkle, which is that if you want to do a migration you are still stuck needing --trust. So we can't do migrations if we want renovate to do PRs for us.
Example migration here: https://github.com/epics-containers/services-template-helm/blob/acf932e71f364e1965f2a6e37a5e47be4bdaa8d6/copier.yml#L9-L26
So if we need to do migrations then can we still put them in there, but that means the user has to do them rather than renovate? In which case this PR is fine by me |
Fixes #270