Skip to content

Conversation

@DiamondJoseph
Copy link
Contributor

@DiamondJoseph DiamondJoseph commented Jun 18, 2025

Fixes #270

@DiamondJoseph
Copy link
Contributor Author

DiamondJoseph commented Jun 18, 2025

There are still two instances of --trust in the codebase: both in a test that checks out main and then updates from main. If it's required to call with --trust when updating an existing project then should this be a major version bump. (fix!: instead of fix:) as it's a change in behaviour depending on if you're updating from a version prior to this than if you're updating only versions post-this? I will check if --trust is required when updating

Copy link
Contributor

@gilesknap gilesknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me.

We should explicitly get the user to do the unsafe stuff and not have any tasks if we can avoid it.

I could also change the ioc-template to do the same thing.

@DiamondJoseph there is one wrinkle, which is that if you want to do a migration you are still stuck needing --trust. So we can't do migrations if we want renovate to do PRs for us.

Example migration here: https://github.com/epics-containers/services-template-helm/blob/acf932e71f364e1965f2a6e37a5e47be4bdaa8d6/copier.yml#L9-L26

@coretl
Copy link
Contributor

coretl commented Jun 19, 2025

@DiamondJoseph there is one wrinkle, which is that if you want to do a migration you are still stuck needing --trust. So we can't do migrations if we want renovate to do PRs for us.

So if we need to do migrations then can we still put them in there, but that means the user has to do them rather than renovate? In which case this PR is fine by me

@DiamondJoseph DiamondJoseph merged commit d48d075 into main Jun 19, 2025
6 checks passed
@DiamondJoseph DiamondJoseph deleted the remove-trust branch June 19, 2025 14:09
@DiamondJoseph DiamondJoseph changed the title fix: Remove need for --trust fix!: Remove need for --trust Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Requiring copier to run with --trust makes automated dependency updates not work

4 participants