-
Notifications
You must be signed in to change notification settings - Fork 1
Migrate to pydantic version 2 #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
=======================================
Coverage 31.85% 31.86%
=======================================
Files 90 90
Lines 10726 10762 +36
Branches 1416 1422 +6
=======================================
+ Hits 3417 3429 +12
- Misses 7193 7215 +22
- Partials 116 118 +2 🚀 New features to boost your workflow:
|
tieneupin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…e_versions' keys in the 'MachineConfig' model; added helper model to correctly validate the magnification calibration table
…ator' to the 'File' BaseModel to do so
tieneupin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made corrections to a few missed spots, and it seems to be working now.
This implements the changes needed for
pydantic2.In doing this, we also upgrade to
sqlalchemy2, so one change has also been made for that.Also this removes the
procrunnerdependency in favour of directly callingsubprocess.Before merging this we need to be able to run MSYS2 or a similar rust-compatible terminal on the microscopes.
Closes #315