Skip to content

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Apr 1, 2025

Resolves issue #554 . Only merge after PR #549.

… pages; switched to using StreamingResponse for package downloads; added debug logs
…de when dynamically generating URLs for downloadable config files
…documentation if HTTP request was passed to server via frontend
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 34.78261% with 15 lines in your changes missing coverage. Please review.

Project coverage is 28.80%. Comparing base (f990500) to head (40e02c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   28.82%   28.80%   -0.03%     
==========================================
  Files          80       80              
  Lines       10578    10596      +18     
  Branches     1412     1413       +1     
==========================================
+ Hits         3049     3052       +3     
- Misses       7427     7442      +15     
  Partials      102      102              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin added documentation Improvements or additions to documentation server Relates to the server component client Relates to the client component labels Apr 1, 2025
@tieneupin tieneupin self-assigned this Apr 1, 2025
@tieneupin tieneupin linked an issue Apr 1, 2025 that may be closed by this pull request
6 tasks
@tieneupin tieneupin marked this pull request as ready for review April 3, 2025 15:25
Copy link
Contributor

@stephen-riggs stephen-riggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd just suggest highlighting more that msys is the preferred terminal now

@tieneupin tieneupin merged commit d8a5133 into main Apr 4, 2025
17 checks passed
@tieneupin tieneupin deleted the improve-msys2-setup-process branch April 4, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Relates to the client component documentation Improvements or additions to documentation server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve bootstrap instructions for MSYS2

2 participants