Use a secure websocket scheme if server is https #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
=======================================
Coverage 28.82% 28.82%
=======================================
Files 80 80
Lines 10578 10578
Branches 1412 1412
=======================================
Hits 3049 3049
Misses 7427 7427
Partials 102 102 🚀 New features to boost your workflow:
|
tieneupin
approved these changes
Apr 4, 2025
Contributor
tieneupin
left a comment
tieneupin
left a comment
There was a problem hiding this comment.
Yes, this looks like it should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may resolve the issues we were seeing when proxying the websocket through https