Delete all references to the global state#567
Merged
stephen-riggs merged 4 commits intomainfrom Apr 11, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 28.75% 28.30% -0.46%
==========================================
Files 80 79 -1
Lines 10619 10474 -145
Branches 1416 1398 -18
==========================================
- Hits 3054 2965 -89
+ Misses 7463 7408 -55
+ Partials 102 101 -1 🚀 New features to boost your workflow:
|
Contributor
|
The deletions looks fine, but I think I'll need more of a history lesson to understand what it's been replaced with in Murfey. If it's not too urgent, I can also checkout this branch, build it, and check that both the TUI and Web UI still work. |
Contributor
|
Will test this after testing PR #563 . |
Contributor
|
Verification Checks
|
d-j-hatton
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't need this any more