Skip to content

Conversation

@gfrn
Copy link
Collaborator

@gfrn gfrn commented Jan 7, 2026

JIRA ticket: LIMS-2025

Summary:

Non-admin users may face permission issues when creating orphan samples (samples without containers), meaning that for the moment being we must create these samples on behalf of the user using SCAUP's token.

Changes:

  • Fix pushing orphan samples to ISPyB as a non-admin user

To test:

This is hard to test, as it requires a non-admin user or changes to Expeye to use a dummy non-admin user for all requests

@gfrn gfrn self-assigned this Jan 7, 2026
@gfrn gfrn added the bug Something isn't working label Jan 7, 2026
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.59%. Comparing base (7c8f16b) to head (600c0a7).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files          42       42           
  Lines        1740     1740           
=======================================
  Hits         1646     1646           
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ndg63276
Copy link
Collaborator

ndg63276 commented Jan 7, 2026

I can't test this easily, but the change is so minor I'm happy to approve if you are!

@gfrn gfrn merged commit 599ce37 into master Jan 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants