[LIMS-2025] Use SCAUP token for upserting orphan samples#24
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
=======================================
Coverage 94.59% 94.59%
=======================================
Files 42 42
Lines 1740 1740
=======================================
Hits 1646 1646
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
I can't test this easily, but the change is so minor I'm happy to approve if you are! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-2025
Summary:
Non-admin users may face permission issues when creating orphan samples (samples without containers), meaning that for the moment being we must create these samples on behalf of the user using SCAUP's token.
Changes:
To test:
This is hard to test, as it requires a non-admin user or changes to Expeye to use a dummy non-admin user for all requests