Skip to content

[LIMS-2066] More descriptive error message for sample with parent/child#28

Merged
gfrn merged 1 commit intomasterfrom
improvement/lims-2066/referenced-sample-error
Jan 29, 2026
Merged

[LIMS-2066] More descriptive error message for sample with parent/child#28
gfrn merged 1 commit intomasterfrom
improvement/lims-2066/referenced-sample-error

Conversation

@gfrn
Copy link
Collaborator

@gfrn gfrn commented Jan 27, 2026

JIRA ticket: LIMS-2066

Summary:

This adds a more descriptive error message for samples which can't be deleted because they have a parent/child sample associated

Changes:

  • More descriptive error message for sample with parent/child

To test:

  • Send a DELETE to /samples/1877, check if 409 is returned

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.64%. Comparing base (0aea769) to head (460eec7).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/scaup/crud/samples.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   94.68%   94.64%   -0.04%     
==========================================
  Files          42       42              
  Lines        1767     1774       +7     
==========================================
+ Hits         1673     1679       +6     
- Misses         94       95       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gfrn gfrn merged commit 82c8ba8 into master Jan 29, 2026
14 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants