Skip to content

Remove leading zeroes from proposal number#29

Merged
gfrn merged 4 commits intomasterfrom
improvement/remove-leading-zeroes
Jan 29, 2026
Merged

Remove leading zeroes from proposal number#29
gfrn merged 4 commits intomasterfrom
improvement/remove-leading-zeroes

Conversation

@gfrn
Copy link
Collaborator

@gfrn gfrn commented Jan 29, 2026

Summary:

Since Matt's Shipping Service no longer requires it, proposal numbers are no longer padded with zeroes

Changes:

  • Remove leading zeroes from proposal number

To test:

  • Create a new shipment, add a dewar, puck, grid box and grid as normal, proceed to the final step where you can book a shipment
  • Book a shipment (make sure you're pointing to the test environment of Matt's Shipping Service)
  • Go to https://sample-shipping-test.diamond.ac.uk/shipment-requests and check if your shipment shows up there, without a leading zero in the proposal

@gfrn gfrn requested review from MattPrit and ndg63276 January 29, 2026 09:43
@gfrn gfrn self-assigned this Jan 29, 2026
@gfrn gfrn added the enhancement New feature or request label Jan 29, 2026
gfrn added 3 commits January 29, 2026 09:44
* Update CHANGELOG

* Increase name length limit (#27)
…dLightSource/scaup-backend into improvement/remove-leading-zeroes
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.68%. Comparing base (0aea769) to head (40751f6).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   94.68%   94.68%           
=======================================
  Files          42       42           
  Lines        1767     1767           
=======================================
  Hits         1673     1673           
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gfrn gfrn merged commit ebc0f14 into master Jan 29, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants