Skip to content

Allow shipping service backend/frontend URLs to be set separately#3

Merged
gfrn merged 2 commits intomasterfrom
feature/lims-1751/shipping-service-urls
May 16, 2025
Merged

Allow shipping service backend/frontend URLs to be set separately#3
gfrn merged 2 commits intomasterfrom
feature/lims-1751/shipping-service-urls

Conversation

@gfrn
Copy link
Collaborator

@gfrn gfrn commented May 16, 2025

JIRA ticket: LIMS-1751

Summary:

Since these may be different (especially when dealing with network topologies which have filters/blocks on them), anyone deploying SCAUP can now set different frontend/backend URLs.

Changes:

  • Allow shipping service backend/frontend URLs to be set separately

To test:

@gfrn gfrn requested review from MattPrit, RichB-DLS and ndg63276 May 16, 2025 10:57
@gfrn gfrn self-assigned this May 16, 2025
@gfrn gfrn added the enhancement New feature or request label May 16, 2025
@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.84%. Comparing base (456ab10) to head (f91f6e5).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   93.89%   93.84%   -0.06%     
==========================================
  Files          38       38              
  Lines        1475     1478       +3     
==========================================
+ Hits         1385     1387       +2     
- Misses         90       91       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@ndg63276 ndg63276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfrn gfrn merged commit ebb9ea6 into master May 16, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants