Skip to content

[LIMS-2107] Update dewar name when code changes#32

Merged
gfrn merged 1 commit intomasterfrom
improvement/lims-2107/update-name-on-code-change
Feb 16, 2026
Merged

[LIMS-2107] Update dewar name when code changes#32
gfrn merged 1 commit intomasterfrom
improvement/lims-2107/update-name-on-code-change

Conversation

@gfrn
Copy link
Collaborator

@gfrn gfrn commented Feb 16, 2026

JIRA ticket: LIMS-2107

Summary:

To prevent confusion, the display name for dewars should change if the code changes, as by default, the name is the dewar code

Changes:

  • Update dewar name when code changes

To test:

  • Send a POST request to /shipments/118/topLevelContainers with {"type": "dewar", "code": "DLS-BI-0020"} as the body, note down the ID
  • Send a PATCH request to /topLevelContainers/{RECENTLY_CREATED_ID} with {"code": "DLS-BI-0022"} as the body, check if the name changes to "DLS-BI-0022" in the database
  • Send a PATCH request to /topLevelContainers/{RECENTLY_CREATED_ID} with {"name": "foo", "code": "DLS-BI-0020"} as the body, check if the name changes to "foo" in the database

@gfrn gfrn requested review from MattPrit and ndg63276 February 16, 2026 13:32
@gfrn gfrn self-assigned this Feb 16, 2026
@gfrn gfrn added the enhancement New feature or request label Feb 16, 2026
@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.65%. Comparing base (82c8ba8) to head (6f6d54a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   94.64%   94.65%           
=======================================
  Files          42       42           
  Lines        1774     1776    +2     
=======================================
+ Hits         1679     1681    +2     
  Misses         95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gfrn gfrn merged commit b0cac74 into master Feb 16, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants