Skip to content

[LIMS-1541] Populate firstExperimendId and dewarRegistryId in dewars#8

Merged
gfrn merged 2 commits intomasterfrom
feature/lims-1541/link-session-to-dewar
Jul 18, 2025
Merged

[LIMS-1541] Populate firstExperimendId and dewarRegistryId in dewars#8
gfrn merged 2 commits intomasterfrom
feature/lims-1541/link-session-to-dewar

Conversation

@gfrn
Copy link
Collaborator

@gfrn gfrn commented Jul 15, 2025

JIRA ticket: LIMS-1541

Summary:

Session IDs and dewar registry IDs are now pushed to Expeye when updating/creating dewars in SCAUP.

Changes:

  • Populate firstExperimendId and dewarRegistryId in dewars

To test:

@gfrn gfrn requested review from MattPrit, RichB-DLS and ndg63276 July 15, 2025 09:50
@gfrn gfrn self-assigned this Jul 15, 2025
@gfrn gfrn added the enhancement New feature or request label Jul 15, 2025
@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.31%. Comparing base (ad7d213) to head (a2d23e1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   94.25%   94.31%   +0.06%     
==========================================
  Files          38       38              
  Lines        1567     1584      +17     
==========================================
+ Hits         1477     1494      +17     
  Misses         90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ndg63276
Copy link
Collaborator

If the name of the dewar in SCAUP won't change, would it make sense to not edit the name in ISPyB as well, just edit the facility code?

@gfrn
Copy link
Collaborator Author

gfrn commented Jul 16, 2025

If the name of the dewar in SCAUP won't change, would it make sense to not edit the name in ISPyB as well, just edit the facility code?

Ultimately, the idea is to make it so that it also changes in SCAUP, so the behaviour with regards to ISPyB is the correct one. It's not a complex change, so it's definitely on the list

@gfrn gfrn merged commit 7e9e15d into master Jul 18, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants