Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 94.25% 94.31% +0.06%
==========================================
Files 38 38
Lines 1567 1584 +17
==========================================
+ Hits 1477 1494 +17
Misses 90 90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
If the name of the dewar in SCAUP won't change, would it make sense to not edit the name in ISPyB as well, just edit the facility code? |
Collaborator
Author
Ultimately, the idea is to make it so that it also changes in SCAUP, so the behaviour with regards to ISPyB is the correct one. It's not a complex change, so it's definitely on the list |
ndg63276
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1541
Summary:
Session IDs and dewar registry IDs are now pushed to Expeye when updating/creating dewars in SCAUP.
Changes:
To test:
continue, thencontinue to pre-session information, submit the form and check if a new dewar was created in ISPyB withfirstExperimentIdanddewarRegistryIdpopulated